engine/iceshard
1
0
Fork 0
Code Issues Pull requests Releases 6 Activity

Task refactor memsys #139

Merged
Dandielo merged 54 commits from task-refactor-memsys into master 2022-10-21 23:47:39 +00:00
Conversation 12 Commits 54 Files changed 418 +13974 -11022
Dandielo commented 2022-08-13 13:27:15 +00:00 (Migrated from github.com)
Copy link
No description provided.
Dandielo (Migrated from github.com) reviewed 2022-10-21 12:48:25 +00:00
source/code/core/collections/public/ice/string/impl/heap_string.inl
@ -0,0 +41,4 @@
{
ice::string::set_capacity(*this, other._size);
// TODO: We need actually very, VERY good tests for string manipulations...
Dandielo (Migrated from github.com) commented 2022-10-21 12:48:24 +00:00
Copy link

Create a task to rebuild string unit tests

Create a task to rebuild string unit tests
Dandielo (Migrated from github.com) reviewed 2022-10-21 12:49:05 +00:00
source/code/core/collections/public/ice/string/impl/static_string.inl
@ -0,0 +304,4 @@
}
template<ice::ucount Capacity, typename CharType>
constexpr auto find_first_of(ice::StaticString<Capacity, CharType> const& str, CharType character_value) noexcept -> ice::ucount
Dandielo (Migrated from github.com) commented 2022-10-21 12:49:05 +00:00
Copy link

Missing 'not_of' variations.

Missing 'not_of' variations.
Dandielo (Migrated from github.com) reviewed 2022-10-21 12:49:33 +00:00
source/code/core/collections/public/ice/string/static_string.hxx
@ -0,0 +82,4 @@
constexpr auto substr_clone(ice::StaticString<Capacity, CharType> const& str, ice::ucount pos, ice::ucount len = ice::String_NPos) noexcept -> ice::StaticString<Capacity, CharType>;
template<ice::ucount Capacity, typename CharType>
constexpr auto find_first_of(ice::StaticString<Capacity, CharType> const& str, CharType character_value) noexcept -> ice::ucount;
Dandielo (Migrated from github.com) commented 2022-10-21 12:49:32 +00:00
Copy link

missing 'not_of' variations

missing 'not_of' variations
Dandielo (Migrated from github.com) reviewed 2022-10-21 12:50:29 +00:00
source/code/core/collections/public/ice/string_types.hxx
@ -12,1 +17,4 @@
using ValueType = CharType const;
using ConstIterator = CharType const*;
using ConstReverseIterator = std::reverse_iterator<CharType const*>;
Dandielo (Migrated from github.com) commented 2022-10-21 12:50:29 +00:00
Copy link

Might want to add conversion from and to std::string_view

Might want to add conversion from and to std::string_view
Dandielo (Migrated from github.com) reviewed 2022-10-21 12:51:37 +00:00
source/code/core/core/public/ice/assert_core.hxx
@ -0,0 +1,19 @@
#pragma once
Dandielo (Migrated from github.com) commented 2022-10-21 12:51:37 +00:00
Copy link

Decide what to do with the old implementation of ICE_ASSERT_CORE

Decide what to do with the old implementation of ICE_ASSERT_CORE
Dandielo (Migrated from github.com) reviewed 2022-10-21 13:02:50 +00:00
source/code/core/modules/private/module_register.cxx
@ -29,19 +29,9 @@ namespace ice
#if ISP_WINDOWS
Dandielo (Migrated from github.com) commented 2022-10-21 13:02:50 +00:00
Copy link

Requires cleanup

Requires cleanup
Dandielo (Migrated from github.com) reviewed 2022-10-21 22:25:47 +00:00
source/code/platforms/platform/private/app_info.cxx
@ -19,3 +19,4 @@
ice::string::begin(path),
static_cast<ice::i32>(ice::string::size(path)),
NULL,
0,
Dandielo (Migrated from github.com) commented 2022-10-21 22:25:46 +00:00
Copy link

Create a task?

Create a task?
Dandielo (Migrated from github.com) reviewed 2022-10-21 22:33:41 +00:00
source/code/systems/resource_system/private/windows/resource_provider_dlls_win32.cxx
@ -189,3 +191,3 @@
private:
ice::Allocator& _allocator;
ice::HeapString<wchar_t> _base_path;
ice::HeapString<ice::wchar> _base_path;
Dandielo (Migrated from github.com) commented 2022-10-21 22:33:41 +00:00
Copy link

To count or not to count?

To count or not to count?
Dandielo (Migrated from github.com) reviewed 2022-10-21 22:35:56 +00:00
Dandielo (Migrated from github.com) left a comment
Copy link

Working on final fixes

Working on final fixes
Dandielo (Migrated from github.com) reviewed 2022-10-21 22:40:44 +00:00
source/code/core/collections/public/ice/string_types.hxx
@ -12,1 +17,4 @@
using ValueType = CharType const;
using ConstIterator = CharType const*;
using ConstReverseIterator = std::reverse_iterator<CharType const*>;
Dandielo (Migrated from github.com) commented 2022-10-21 22:40:44 +00:00
Copy link

For now we will make explicit conversions between these two

For now we will make explicit conversions between these two
Dandielo (Migrated from github.com) reviewed 2022-10-21 22:44:45 +00:00
source/code/systems/resource_system/private/windows/resource_provider_dlls_win32.cxx
@ -189,3 +191,3 @@
private:
ice::Allocator& _allocator;
ice::HeapString<wchar_t> _base_path;
ice::HeapString<ice::wchar> _base_path;
Dandielo (Migrated from github.com) commented 2022-10-21 22:44:45 +00:00
Copy link

For now this was an exception so we keep the constructor that sets the count to the array size encountered.

For now this was an exception so we keep the constructor that sets the count to the array size encountered.
Dandielo (Migrated from github.com) reviewed 2022-10-21 22:57:17 +00:00
Dandielo (Migrated from github.com) left a comment
Copy link

Windows is ready to roll

Windows is ready to roll
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bot
Issue created by a bot / workflow.

  
bug
Something isn't working

  
documentation
Improvements or additions to documentation

  
duplicate
This issue or pull request already exists

  
enhancement
Improvements or additions to code

  
feature
Request for a new feature or functionality

  
help wanted
Extra attention is needed

  
organization
Used for issues or discussions that are used to organize work on the project.

  
question
Further information is requested

  
tech-debt
Technical debt that needs to be addressed, but can be tolerated for some time

No labels
bot
bug
documentation
duplicate
enhancement
feature
help wanted
organization
question
tech-debt
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
engine/iceshard!139
No description provided.