Milestone 1105050722 #127
No reviewers
Labels
No labels
bot
bug
documentation
duplicate
enhancement
feature
help wanted
organization
question
tech-debt
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
engine/iceshard!127
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "milestone-1105050722"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
This is the final issues of the "Font and UI" milestone. Any additional major changes are going to be addressed here.
@ -48,6 +48,26 @@"executable": "%VULKAN_SDK%/Bin/glslc.exe","options": [ "--target-env=vulkan", "-fshader-stage=frag", "-o", "sprite-pix.spv", "sprite-pix.glsl" ]},{Planned improvements to remove all the code duplication. #128
@ -22,6 +22,9 @@ namespace iceusing uptr = std::uintptr_t;using usize = ice::u64;A quick change preceding a bigger refactor: #129
Remove 'Sleep' call from
task_thead_v2::run@ -49,0 +60,4 @@ice::stringid_hint(name));// TODO: To be refactored with the planned introduction of a proper 'size' type.Part of #129
Part of #130
@ -50,1 +50,4 @@bool requested_exit() const noexcept override{return ice::shards::contains(_runner->previous_frame().shards(), "action/game/exit"_shard);Requires documentation in code and on the wiki pages.
@ -75,3 +94,6 @@ namespace icetemplate<>Might want to start separating some parts of this file.
Delete
Remove all the unnecessary comments.
@ -178,6 +178,29 @@ namespace icereturn object_ptr;Part of: #129
@ -0,0 +1,7 @@#include <ice/font.hxx>Remove this file?
Add a in-code comment how this works.
@ -0,0 +1,12 @@#pragma onceRemove this file?
@ -0,0 +1,25 @@#pragma onceRemove this type?
@ -0,0 +44,4 @@ice::Span<ice::ui::UIResourceData const> resources) noexcept -> ice::ui::UpdateResult;static constexpr ice::ui::UpdateStage Constant_UpdateStageOrder[]{This is not usable, ale actual logic is more complicated.
@ -0,0 +5,4 @@namespace ice::ui{struct DrawDataUnused?
@ -0,0 +1,30 @@#pragma onceClean up this file.
@ -0,0 +1,88 @@#pragma onceAdd some static_assert tests.
This could be replaced with
ice::shards::transform_all, but need double checking.@ -0,0 +1,6 @@{"asset": {Remove this file.
@ -0,0 +37,4 @@Font* gfx_font = reinterpret_cast<Font*>(data);FontAtlas* gfx_atlas = reinterpret_cast<FontAtlas*>(ice::memory::ptr_align_forward(gfx_font + 1, alignof(FontAtlas))); // TODO: Multi-atlas supportCreate a task for font-atlas support and another for multiple atlasses in one font asset.
@ -0,0 +124,4 @@msdf_atlas::FontGeometry geometry{ &glyphs };msdf_atlas::Charset charset = msdf_atlas::Charset::ASCII;// TODO: Properly support bigger charsets.Create a issues for handling big utf8 character sets.
@ -0,0 +1,356 @@#include "ip_ui_oven_elements.hxx"Might need to change this one into a follow up issue.
@ -0,0 +133,4 @@//ice::usize const type_end = str.find_first_of(u8' ');//ice::Utf8String const data_type = str.substr(0, type_end);//if (out_action.action_type == ice::ui::ActionType::ShardThis might be a follow up issues, as currently there is no use case to have this solved.
@ -0,0 +1,367 @@#include <ice/ui_element.hxx>Might be a bug?
This does not work, as prev_frame is immutable, and we cannot mutate shards.
Bu we might add a new api to move and transform shards from one array to another.
A few more changes required but we are comming to an end of this milestone!
@ -0,0 +1,6 @@{"asset": {Or not ;d
@ -0,0 +37,4 @@Font* gfx_font = reinterpret_cast<Font*>(data);FontAtlas* gfx_atlas = reinterpret_cast<FontAtlas*>(ice::memory::ptr_align_forward(gfx_font + 1, alignof(FontAtlas))); // TODO: Multi-atlas supportCreated #132
@ -0,0 +124,4 @@msdf_atlas::FontGeometry geometry{ &glyphs };msdf_atlas::Charset charset = msdf_atlas::Charset::ASCII;// TODO: Properly support bigger charsets.Create #133
@ -0,0 +1,356 @@#include "ip_ui_oven_elements.hxx"For now we removed this code, as we might not need it for a longer time. If that's the case we would anyway need to re-visit most of the code.
@ -0,0 +133,4 @@//ice::usize const type_end = str.find_first_of(u8' ');//ice::Utf8String const data_type = str.substr(0, type_end);//if (out_action.action_type == ice::ui::ActionType::ShardFor now there is no known situation where we would need to send additional data with shards.
This issues might need a revisit at a later point. #134
@ -0,0 +1,367 @@#include <ice/ui_element.hxx>For now this will be not addressed. As there is no need for the anchoring feature.
We are approaching the end of this milestone. Just missing colors to have an MVP at this point.
Features finished.
Last remaining thing are fixes on Linux.
We might keep it for now, and extend the API to have access to simmilar functions across platforms.
Added minimal documentation for fonts and UI: