Milestone "Resources, Assets and UI" #109

Merged
Dandielo merged 95 commits from milestone-0501290322 into master 2022-04-12 21:38:12 +00:00
Dandielo commented 2022-01-19 00:02:53 +00:00 (Migrated from github.com)

The following issues will be updated:

  • closes #61
The following issues will be updated: * closes #61
Dandielo commented 2022-04-10 23:16:17 +00:00 (Migrated from github.com)

closes #62

closes #62
Dandielo commented 2022-04-10 23:19:24 +00:00 (Migrated from github.com)

Final fixes for unix are required. But the milestone is wrapped up for the Resource and Asset API refactors.

Additional work will be built uppon it.

Final fixes for unix are required. But the milestone is wrapped up for the Resource and Asset API refactors. Additional work will be built uppon it.
Dandielo (Migrated from github.com) reviewed 2022-04-11 20:19:31 +00:00
@ -40,2 +40,4 @@
} // namespace ice
//! \brief This macro is required for a bug apprearing in the MSVC compile when generating optimized code with /O2
Dandielo (Migrated from github.com) commented 2022-04-11 20:19:30 +00:00

This issue was also observed in other locations. Maybe the coroutine API is not properly defined?

This issue was also observed in other locations. Maybe the coroutine API is not properly defined?
Dandielo (Migrated from github.com) reviewed 2022-04-11 20:41:30 +00:00
@ -14,0 +20,4 @@
static_assert(Constant_IsHandleSupported, "The given handle type is not supported by ice::win32::SafeHandle!");
public:
Dandielo (Migrated from github.com) commented 2022-04-11 20:41:30 +00:00

This class is kind of helpful, but should be replaced / improved later. Create a tech-debt issue after closing #95.

This class is kind of helpful, but should be replaced / improved later. Create a tech-debt issue after closing #95.
Dandielo (Migrated from github.com) reviewed 2022-04-11 20:44:23 +00:00
@ -0,0 +10,4 @@
namespace ice
{
class SimpleTaskThread_v2 : public ice::TaskThread_v2
Dandielo (Migrated from github.com) commented 2022-04-11 20:44:23 +00:00

A tech-debt cleanup is required for the whole coroutine scheduling API. Mostly because with the current approach using Tracy with Fibers is almost impossible. (#95)

A tech-debt cleanup is required for the whole coroutine scheduling API. Mostly because with the current approach using Tracy with Fibers is almost impossible. (#95)
Dandielo (Migrated from github.com) reviewed 2022-04-11 22:25:30 +00:00
@ -6,3 +5,3 @@
#include <fmt/format.h>
#include <ice/log_formatters.hxx>
namespace ice::detail
Dandielo (Migrated from github.com) commented 2022-04-11 22:25:30 +00:00

A smaller revisit of the logging API is needed so we can finally support utf8 values. (post-#95)

A smaller revisit of the logging API is needed so we can finally support utf8 values. (post-#95)
Dandielo (Migrated from github.com) reviewed 2022-04-11 22:27:24 +00:00
@ -0,0 +6,4 @@
{
template<bool IsValidated = false>
struct UserdataBase
Dandielo (Migrated from github.com) commented 2022-04-11 22:27:23 +00:00

This type might come in handy, but more test are required to see if we can in release builds just replace it with a void* (post #95)

This type might come in handy, but more test are required to see if we can in release builds just replace it with a `void*` (post #95)
Dandielo (Migrated from github.com) reviewed 2022-04-11 22:36:39 +00:00
@ -74,3 +57,4 @@
app_result = game_main(game_alloc, *resource_tracker);
}
ice::memory::shutdown();
Dandielo (Migrated from github.com) commented 2022-04-11 22:36:39 +00:00

Add basic command line arguments. (post #95)

Add basic command line arguments. (post #95)
Dandielo (Migrated from github.com) reviewed 2022-04-11 22:38:10 +00:00
@ -18,1 +15,4 @@
// using ice::gfx::Model;
// using ice::gfx::Mesh;
// using ice::gfx::Vertice;
Dandielo (Migrated from github.com) commented 2022-04-11 22:38:10 +00:00

Revive at some point the Mesh asset. (post #95)

Revive at some point the Mesh asset. (post #95)
Dandielo (Migrated from github.com) reviewed 2022-04-11 22:40:59 +00:00
Dandielo (Migrated from github.com) left a comment

Checked. Remaining thing is to address conversations and create new tasks / issues.

Checked. Remaining thing is to address conversations and create new tasks / issues.
Dandielo (Migrated from github.com) reviewed 2022-04-12 21:22:24 +00:00
@ -40,2 +40,4 @@
} // namespace ice
//! \brief This macro is required for a bug apprearing in the MSVC compile when generating optimized code with /O2
Dandielo (Migrated from github.com) commented 2022-04-12 21:22:23 +00:00
https://github.com/iceshard-engine/engine/issues/111
Dandielo (Migrated from github.com) reviewed 2022-04-12 21:26:52 +00:00
@ -14,0 +20,4 @@
static_assert(Constant_IsHandleSupported, "The given handle type is not supported by ice::win32::SafeHandle!");
public:
Dandielo (Migrated from github.com) commented 2022-04-12 21:26:52 +00:00

Created #112

Created #112
Dandielo (Migrated from github.com) reviewed 2022-04-12 21:27:21 +00:00
@ -0,0 +10,4 @@
namespace ice
{
class SimpleTaskThread_v2 : public ice::TaskThread_v2
Dandielo (Migrated from github.com) commented 2022-04-12 21:27:20 +00:00

Can be taken under the umbrella of #112

Can be taken under the umbrella of #112
Dandielo (Migrated from github.com) reviewed 2022-04-12 21:28:28 +00:00
@ -6,3 +5,3 @@
#include <fmt/format.h>
#include <ice/log_formatters.hxx>
namespace ice::detail
Dandielo (Migrated from github.com) commented 2022-04-12 21:28:28 +00:00

An issues already exists #103

An issues already exists #103
Dandielo (Migrated from github.com) reviewed 2022-04-12 21:30:00 +00:00
@ -0,0 +6,4 @@
{
template<bool IsValidated = false>
struct UserdataBase
Dandielo (Migrated from github.com) commented 2022-04-12 21:29:59 +00:00

To be seen if we need this, and what would be the impact.

To be seen if we need this, and what would be the impact.
Dandielo (Migrated from github.com) reviewed 2022-04-12 21:32:43 +00:00
@ -74,3 +57,4 @@
app_result = game_main(game_alloc, *resource_tracker);
}
ice::memory::shutdown();
Dandielo (Migrated from github.com) commented 2022-04-12 21:32:43 +00:00

Created #113

Created #113
Dandielo (Migrated from github.com) reviewed 2022-04-12 21:34:14 +00:00
@ -18,1 +15,4 @@
// using ice::gfx::Model;
// using ice::gfx::Mesh;
// using ice::gfx::Vertice;
Dandielo (Migrated from github.com) commented 2022-04-12 21:34:14 +00:00

Created #114

Created #114
Sign in to join this conversation.
No description provided.